Merged
Conversation
…e to text-based framing protocol (print and createChar)
… work due to text-based framing protocol (print and createChar)" This reverts commit d61ef40.
Owner
|
Wow, this is awesome! I'm pretty impressed that it was only a small change to du.ino. I'm traveling right now, so I'll take a deeper look at this when I get back. Really appreciate your effort on this. |
|
@ecto is this likely to get merged in? |
Contributor
Author
There was a problem hiding this comment.
I can't really recall if there was a particular reason or not, but unless you're doing something fancy when loading subcomponents, they are module-scoped and shouldn't affect (or be affected by) anyone else's code.
Owner
|
Hey, sorry for the horrifically long wait. I was traveling again, moving, working, etc. and forgot about this. Merging now :) |
Owner
|
Also hell yeah. Great work |
Contributor
Author
|
Thanks, glad you like it! (And thanks again @andyet / @adambrault for sponsoring the project :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would love to see these changes integrated into trunk. On my branch I have:
Big thanks to &yet for sponsoring this open source work!